feat: set default ignoredUnrecoverableEvents #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuznyetsov
requested review from
SDawley,
tolusha and
ibuziuk
as code owners
5 tasks
AObuchow
reviewed
Sep 9, 2024
bundle/next/eclipse-che/manifests/org.eclipse.che_checlusters.yaml
Outdated
Show resolved
Hide resolved
mkuznyetsov
force-pushed
the
dwo-1280
branch
2 times, most recently
from
19c2a72 to
f8e0ab8
Compare
dkwon17
requested changes
Sep 11, 2024
mkuznyetsov
force-pushed
the
dwo-1280
branch
from
85d1d63 to
78e3747
Compare
|
@mkuznyetsov could you please fix the conflict? |
mkuznyetsov
force-pushed
the
dwo-1280
branch
from
78e3747 to
78842a0
Compare
Signed-off-by: Mykhailo Kuznietsov <[email protected]>
mkuznyetsov
force-pushed
the
dwo-1280
branch
from
78842a0 to
b225626
Compare
|
/retest |
|
@mkuznyetsov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
It looks good to me: Screencast.from.2024-09-17.11-59-48.webmHello @tolusha could you please review? |
tolusha
approved these changes
Sep 18, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkuznyetsov, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.17 :: operator_3.x/399: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.x/7712: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7704 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.17 :: operator-bundle_3.x/3614: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7712 triggered |
|
Build 3.17 :: copyIIBsToQuay/2793: Console, Changes, Git Data |
|
Build 3.17 :: dsc_3.x/1999: Console, Changes, Git Data |
|
Build 3.17 :: dsc_3.x/1999: 3.17.0-CI |
|
Build 3.17 :: copyIIBsToQuay/2792: 3.17 |
|
Build 3.17 :: copyIIBsToQuay/2793: 3.17 |
|
Build 3.17 :: operator-bundle_3.x/3615: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.x/7714: Console, Changes, Git Data |
|
Build 3.17 :: push-latest-container-to-quay_3.x/4929: Console, Changes, Git Data |
|
Build 3.17 :: copyIIBsToQuay/2794: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.x/7714: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7706 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.17 :: operator-bundle_3.x/3615: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7714 triggered |
|
Build 3.17 :: dsc_3.x/2000: Console, Changes, Git Data |
|
Build 3.17 :: dsc_3.x/2000: 3.17.0-CI |
|
Build 3.17 :: copyIIBsToQuay/2794: 3.17 |
|
Build 3.17 :: operator-bundle_3.x/3616: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.x/7717: Console, Changes, Git Data |
|
Build 3.17 :: push-latest-container-to-quay_3.x/4931: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.x/7717: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7708 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.17 :: operator-bundle_3.x/3616: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7717 triggered |
|
Build 3.17 :: copyIIBsToQuay/2795: Console, Changes, Git Data |
|
Build 3.17 :: dsc_3.x/2001: Console, Changes, Git Data |
|
Build 3.17 :: dsc_3.x/2001: 3.17.0-CI |
|
Build 3.17 :: copyIIBsToQuay/2795: 3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add FailedScheduling event by default to the list of ignored unrecoverable events.
Original DWO PR (to be closed): devfile/devworkspace-operator#1310
Related issue: devfile/devworkspace-operator#1280
Related docs issue: eclipse-che/che-docs#2789
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
OpenShift
on Minikube
To test how FailedScheduling event will be ignored by default with these changes:
To test, if FailedScheduling can be configured to not be ignored (pre-PR behaviour)
set spec.devEnvironments.ignoredUnrecoverableEvents field to an empty array:
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.